st/amelie

Fork 0

fable-cleanup #45

Merged

st merged 94 commits from fable-cleanup into main

2026-07-15 01:08:27 +02:00

st commented

2026-07-15 01:06:40 +02:00

Owner

No description provided.

st added 94 commits

2026-07-15 01:06:40 +02:00

audit: add docs/simplification-audit.md 87531e44f0

Six-agent whole-compiler audit synthesis + 4-phase migration plan.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

phase 0: dead code, dead surface, renames, doc truth (simplification-audit) f2a3ec8f05

comment sweep: delete narrative/stale/restating comments per CLAUDE.md rule 9fe49a2650

phase 1: parser separated_list combinator 24f7f011b4

phase 1: generic ty/nat iterator in types.ml fdb5608501

phase 1: generic Ir evidence/expr iterator in infer.ml 404e735c31

phase 1: collapse infer Internal* exception zoo 431a23b4f9

phase 1: backend classifier/layout/pair-builder consolidation 53743b157f

phase 1: driver consolidation (error currency, Engine extraction, ctx/gen merges) 787330700d

repr overhaul: Box vs raw Ptr; telescopes.md replaces closures.md 109efcef32

phase 2a plan: one constraint currency (Obligation.t) 5ea0d75a54

phase 2a step 1: Obligation.t hosted in Types; Eq->Proj afff74e061

phase 2a step 2: instantiate_with_all returns obligations b653a6461d

phase 2a step 3: Ir.dict_mapping carries obligations bafb78952a

phase 2a step 4: schemes carry obligations; one instantiate 779421724f

phase 2a step 5: worklist payload is Obligation.t 2f4ba71287

phase 2a step 6: evidence layers carry Obligation.t bf2ee61c6f

phase 2a step 7: docs + audit F3 ledger 60603a0625

phase 2a fix round: review findings 82967d290a

trim readme c862fa6f39

delete pre-Evidence substitution seam 90fb1b6bed

phase 2b plan: solve worklist stage 2 (type-level half) 5250881ec8

phase 2b step 1: one reducer reduce_assoc (Deep|Whnf) c01f631346

phase 2b step 2: worklist mechanics (inert) 672e7416df

phase 2b step 3: Proj is a worklist citizen fcd7fb3262

phase 2b step 4: one dispatch classifier f3a87ac0b3

phase 2b step 5: docs + audit F4 ledger 339645082a

remove adversarial-review skill (too token-hungry) f27a3e736f

phase 2b fix round: force-fire oldest-first; findings 56659635c9

restore adversarial-review skill (lean) bb7bb04b93

2c plan: one promotion entry, infer_instance, parity, one Sized spelling 8288ea6623

Self-review probes found 2 latent segfault families, fixed by design.
Plan + decision tables: docs/plans/finish-phase-2.md

2c step 1: REPL entry paths run the package normalizer 9b54c27781

Pin: test_prompt_assoc_const. Session-instance gap ledgered (plan F7).

2c step 2: delete the Obligation.Sized arm; Iface{"Sized"} is the one spelling ed48e5f5a5

2c step 3: decompose infer_decl_exn into per-decl-form functions (pure motion) d5ab262558

2c step 4: generalize_group, THE promotion entry; route Fn arm + values cd2918f732

Inherited sets prune to principal constraints before BOTH views,
fixing the promoted-entailed-pair segfault (plan F1, singleton).

2c step 5: route the SCC path through generalize_group 3eafb16fed

Members gain ambiguity check, protect-set, inferred-Flat;
union-set pruning fixes the F1 segfault, SCC half.

2c step 6: instance privates union-promote through generalize_group 8a9d543c63

Fixes the constrained-private segfaults (plan F2, F9); 6 JIT pins.

2c step 7: delete dead promotion helpers; re-pin the audit ledger 353c7573ee

CLAUDE.md: keep jj revision descriptions short ce565e1c39

2c fix round: generalize_value standalone; mixed groups checked-as-declared 0500bb13e6

Review blocker R1 (values generalize mid-body — never default there) +
R2 (baking unsound when seeds refresh); 7 pins, suite 1078.
Decision table: docs/plans/finish-phase-2.md

phase 3 prep: resolution conformance suite 965d9ae3df

phase 3 A1: namespace tree (children, enum variants, iface_info nodes) d6c1fc870b

phase 3 A2: one projection funnel (child edges, node variants, lexical-first) 312f9b08ba

phase 3 A3: use paths as uniform namespace walks 082b26f8d6

phase 3 A4: interface metadata lives on nodes; five side tables die d8c652b672

phase 3 rung A fix round: review findings b364e2a4f9

phase 3 B1-1: resolve's manglers die into Mangle.symbol 2221177fa3

phase 3 B1-2: namespace nodes + funnel projection; flatten machinery dies cf4e1fb07f

r3_prog_ctor_d2 gap closed (promoted to expect). local_modules /
dotted_path_of / flatten_namespaces deleted; symbols derived via Mangle.

phase 3 B1-3: conformance pins for B1 (4 cells) + docs bcb1ddd060

Payload-sibling gap discovered and pinned; probe-vehicle lesson in the plan.

phase 3 B1 fix round: review findings 105942cd8f

phase 3 B2-1: the pooled SCC artifact is the loader/frontend boundary b43afaed6e

pm_* dies; Dependency runs in compile_package; instance owner tags zip
structurally (map2, loud on mismatch).

phase 3 B2-2: child bindings from the registry's edges; child_modules dies c7ec916901

phase 3 B2-3: docs + step-0 status a8ca1c568d

phase 3 B2 fix round: review findings 1650502532

Own-children scoped to package_units (cross-package child adoption leak,
pinned); named invariant failure on instance-tag mismatch.

phase 2 rung 3 R3-1: three-valued Solve fire + improve_dispatch progress signal ce2c90473e

phase 2 rung 3 R3-2: improvement fires at quiescence (parked Iface items) 6724d2ec00

Ordering pin: fd source pinned after the call now improves the literal
(pre-R3: NoInstance for the defaulted participant).

phase 2 rung 3 R3-3: docs 4b54851228

phase 2 rung 3 fix round: review findings + design boundary 40d2e3346c

Error-kind delta pinned (eager/quiescent unify consistency); fire-order
documented; obligation.ml phase map; alias/comment residue. Recorded the
refined design boundary: participants are resolution-relevant, assoc types
are deliberately dispatch-inert (not sugar over fundeps).

phase 3 driver D1: session/UI state split 6a2e19af42

phase 3 driver D2: Engine + session core extracted to engine.ml cf30e67fde

phase 3 driver D3: maintained session namespace; module-ctx recomputes die 2e947fe8b7

phase 3 driver: plan doc split note 2552626a69

phase 3 driver part-1 fix round: review findings 43632b81eb

session_ns rebuilds on redefinition (review blocker, pinned); lifted decls
join the fold; mli type equation; export trim.

phase 3 driver D4: run_decls + prompt namespaces + instance lowering 1d0c0590e4

phase 3 driver D4 fix round: review findings 2ec53edbaa

phase 3 driver D5: session-instance dispatch 4be2cd0610

phase 3 driver D5 fix round: review findings 2d8186662b

phase 3 driver D6: annotation converter, reload announce, clean errors b639706156

phase 3 driver D6 fix round: review findings a57d0843b0

phase 3 driver D7: docs closure — reshape complete 4bdc9a1c11

phase 3 r1: plan — variants leave the module export surface e349df894d

phase 3 r1: variants leave the module export surface 879452ae15

phase 3 r1 fix round: review findings 589cb77ccf

phase 3 q1: plan — one value-symbol policy + self_name death 307591178c

phase 3 q1-1: one value-member symbol policy (Mangle.member_symbol) e86cf25153

phase 3 q1-2: self_name death — a module in its own environment 0a41ba8a8a

phase 3 q1 fix round: review findings c52c0e5c1e

phase 3 3b: plan — structured annotation resolution d249086cac

phase 3 3b-ii: structured member refs (Ir.mscope) 81313ce3d3

phase 3 3b: re-plan — type identity uniqueness 68b9fd0730

phase 3 3b-c.1: tyscope namespace path as segment list 03aa130500

phase 3 3b stage 2: module-rooted structured type identity a3dec01eef

type_defs keyed by structured Types.qualid (mangle confined to codegen +
size/matching layout bridge); refs/annotations carry Syntax.type_origin
(VariantLit/QualifiedVariantLit merged; StructLit threaded; TResolved for
annotations; patterns via scrutinee qualid). Fixes same-named-type collisions
across modules. Reviewed (adversarial diff) + fix round folded in. Suite 1185.
Plan+decision tables: docs/plans/type-identity-uniqueness.md.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

phase 3 F10-R1: de-bake nested-type reference identity 44786ca875

VVariant carries the enum's structured owner (OInstance/ONamespace) instead
of a mangled name; variant/type-namespace refs resolve to the structured
qualid. Deletes the hoisted_flat_ref/flat_of_tref reverse-map and the
register_type_def dual-key. Suite 1185. Plan docs/plans/nested-type-identity-debake.md

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

phase 3 F10-R1 fix round: review findings 52edc55ae5

Disambiguate DuplicateVariant message by readable owner (namespace path /
instance head), not the mangled symbol. Reviewer decision table in the plan.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

phase 3 F10-R2: structure field types + de-bake layout to per-owner 4ea10bab28

Struct/enum field-type annotations are structured (TResolved); size.ml and
codegen field-layout resolve nominal types by their structured qualid, not a
bare source name, so infer+size+codegen agree per-owner. Fixes the cross-module
layout collision (a same-named unboxed field miscompiled to garbage). size.ml is
mangle-free; the infer adapter's string table + bare alias are gone. Reviewed
(one fresh-context reviewer, 5 both-builds probes) + fix round: nested-enum-payload
collision + dead codegen alias ledgered (F10). Suite 1188.
Plan docs/plans/structure-field-type-annotations.md

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

phase 3 F10-R3 (A): source-name the type backend fields 29fee2415a

Namespace/instance hoisted type defs keep their SOURCE name in struct_name/
enum_name (the structured origin is their identity; lowering derives the flat
symbol) for every expressible case; the instance-nested case stays flat (F).
The three session seams that keyed type redefinition by the name (repl node key,
ns_symbols_under drop-set, land_unit dedup) now key by the owner-derived symbol.
The codegen ~base alias is KEPT (serves nested-pattern bare lookups — C rides
with B). Reviewed + fix round (land_unit blocker). Behavior-preserving; suite 1189.
Plan docs/plans/type-backend-field-debake.md

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

phase 3 F10-R4 (B+C): nested-enum-payload per-owner + drop the alias 5954df2260

codegen extract_bindings derives a nested subpattern's type from the parent
variant's payload under the scrutinee's type-arg substitution (retiring the
ownerless subpattern_field_ty); matching keys the payload enum_lookup by the
structured qualid. Both per-owner, so the codegen ~base source-name alias is
DELETED. A same-named enum as a nested variant payload now evaluates correctly
(pin -> expect_lib=11). Reviewed + fix round (payload arg-propagation blocker).
Suite 1190. Plan docs/plans/nested-payload-debake.md

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

phase 3 F10-R5 (E): bare-program SInteractive 26ae70ac20

A bare (anonymous) program's top-level types are now genuinely path-less
(SInteractive), not module-rooted under the synthetic filename: bare -> resolve
with self_name=None and skip stamp_owner (the two agree). Reviewed CLEAN
(byte-identical IR; a latent same-named-import collision is fixed). Suite 1190.
Plan docs/plans/bare-program-sinteractive.md

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

phase 3 F10-R6 (F): composed origin for instance-nested-namespace types 0a3135bc98

Types in a namespace nested inside an instance body get a STRUCTURED composed
identity: OInstance/SInstance gain an ns (namespace-path) field, so
origin_of_local never returns None and the last (mangled, None) type currency
is gone. register_module_decl's instance arm descends into nested namespaces,
registering their variants under the composed owner — closes the r4 gap
(gap -> expect=7). Mangle.symbol composes byte-identically (reviewer-verified
via byte-identical LLVM). Reviewed CLEAN. Suite 1190.
Plan docs/plans/composed-origin.md

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

phase 3 F10-R7 DA: fn/const decl scope field (inert plumbing) 5cd386e22d

fn_decl/const_decl gain scope : Ir.mscope (mirror of the reference-side mscope);
Ir.decl_component derives a value decl's flat member component from (source name,
scope). Populated at the namespace hoist site via mscope_of_lns while the .name
stays mangled -> inert. Sets up the DB flip. Suite 1190.
Plan docs/plans/fn-decl-scope.md

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

phase 3 F10-R7 DB: fn/const source-name + re-key — F10 CLOSED 23a56e9fb5

Hoisted namespace/instance fn/const decls keep their SOURCE name; their flat
symbol derives at lowering from the structured scope (decl_component), like a
reference's. Every identity site across dependency/infer/specialize/codegen/repl/
engine re-keyed to the component (byte-identical values). resolve no longer
mangles a fn/const name. Reviewed + fix round (const_closures blocker twin of
const_gens; module_sig symmetry). No mangled string is any decl's identity
during analysis. Pins: two-namespace same member (=30); namespace const closure
(=42). Suite 1191. Plan docs/plans/fn-decl-scope.md

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

compaction: dead-export sweep 21a81ac93c

Drop Infer.thread_sccs from the .mli (internal-only callers) and delete the
dead Namespace.iface_method_names (zero callers).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

compaction F6a: generic ty map_children/iter_children combinators 8d815b6489

The ONE enumeration of ty's structural arms; consumers handle their own leaves
(scalars/TVar) + nat policy and delegate the structural arms. Adopted in
apply (instantiation), iter_vars, collect_bound_tvars, and show_with_names'
collect — collapsing ~4x the repeated arms. Behavior-preserving; suite 1192.
Foundation for the F6 cluster (nat unify, TClosure move, types.ml split).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

audit: bank compaction harvest; F8/F9 withdrawn as compaction levers e8a44c5492

F8 byte-vs-word walker unify = false duplicate (repr/generality/measure/
failure-policy diverge). F9 premise false: codegen reads type_params/
propositions to lay out runtime evidence dicts (backend is repr-mono but
iface-poly). Harvest banked; suite 1192.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>